Re: [Xen-devel] [PATCH] xen: remove redundant put_device

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Sep 06, 2018 at 02:33:10PM +0800, Ding Xiang wrote:
> device_unregister will put device, do not need to do it one more time
> 
> Signed-off-by: Ding Xiang <dingxiang@xxxxxxxxxxxxxxxxxxxx>
> ---
>  drivers/xen/xenbus/xenbus_probe.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/xen/xenbus/xenbus_probe.c 
> b/drivers/xen/xenbus/xenbus_probe.c
> index 5b47188..cfaa878 100644
> --- a/drivers/xen/xenbus/xenbus_probe.c
> +++ b/drivers/xen/xenbus/xenbus_probe.c
> @@ -369,7 +369,6 @@ static void xenbus_cleanup_devices(const char *path, 
> struct bus_type *bus)
>               bus_for_each_dev(bus, NULL, &info, cleanup_dev);
>               if (info.dev) {
>                       device_unregister(&info.dev->dev);
> -                     put_device(&info.dev->dev);

This is to match the get_device call in cleanup_dev. It is not redundant
IMHO.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel