Re: [Xen-devel] [PATCH v3 07/16] x86/p2m/pod: make it build with !CONFIG_HVM

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Sep 04, 2018 at 06:24:28PM +0100, Julien Grall wrote:
> Hi Wei,
> 
> On 09/04/2018 05:15 PM, Wei Liu wrote:
> > Populate-on-demand is HVM only.
> > 
> > Provide a bunch of stubs for common p2m code and guard one invocation
> > of guest_physmap_mark_populate_on_demand with is_hvm_domain.
> > 
> > Put relevant fields in p2m_domain and code which touches those fields
> > under CONFIG_HVM.
> 
> Arm does not have any POD support. Would it be worth to introduce a
> CONFIG_HAS_POD to avoid dummy function on Arm?

That sounds fine. This will have the effect of not compiling PoD on Arm
at all, which is good.

I will wait for more reviews before reworking this patch.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel