Re: [Xen-devel] [PATCH v3 02/16] x86: introduce and use a set of internal emulation flags

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Sep 06, 2018 at 07:27:47AM -0600, Jan Beulich wrote:
> >>> On 04.09.18 at 18:15, <wei.liu2@xxxxxxxxxx> wrote:
> > Use these flags in has_* tests and emulation_flags_ok.
> > 
> > Not using raw flags directly enabling DCE to kick in for has_* tests
> > while at the same time making sure emulation_flags_ok won't go out of
> > sync.
> 
> This is rather hard to read (for me at least). Perhaps s/enabling/enables/
> and split sentences after the first line, or at least put a comma
> somewhere?

There were some grammar errors. The commit message has been updated to:

 Not using raw flags directly enables DCE to kick in for has_* tests,
 while at the same time makes sure emulation_flags_ok won't go out of
 sync.

> 
> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> 
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Thanks.

Wei.

> 
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel