Re: [Xen-devel] [PATCH v2 11/11] vpci/sriov: add support for SR-IOV capability

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Thu, Sep 06, 2018 at 11:37:28AM +0100, Wei Liu wrote:
> On Tue, Jul 17, 2018 at 11:48:30AM +0200, Roger Pau Monne wrote:
> > +            curr->vpci.wait.callback = enable_callback;
> > +            curr->vpci.wait.data = cb;
> > +            curr->vpci.wait.end = get_cycles() + 100 * cpu_khz;
> 
> Does this guarantee to give you 100ms? What if the TSC is not constant
> (invariant? forgot which name is which) ?
> 
> I think you might want to use NOW() and friends in time.c

Right, I originally copied this from __udelay, but using NOW is indeed
better.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel