Re: [Xen-devel] [PATCH] perfc: Print a system time in a convenient format

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 11.09.18 at 08:53, <andrii.anisov@xxxxxxxxx> wrote:
> --- a/xen/common/perfc.c
> +++ b/xen/common/perfc.c
> @@ -33,8 +33,7 @@ void perfc_printall(unsigned char key)
>      unsigned int i, j;
>      s_time_t now = NOW();
>  
> -    printk("Xen performance counters SHOW  (now = 0x%08X:%08X)\n",
> -           (u32)(now>>32), (u32)now);
> +    printk("Xen performance counters SHOW  (now = %"PRI_stime")\n", now);

NAK, for two reasons: I'm not of the opinion that reading a 15 or more
digit decimal number without any separators is any easier than the
current format. And then if you/we were to change this, then please
uniformly everywhere - there's even a second instance right in this
same file you change, not to speak of similar ones elsewhere.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel