Re: [Xen-devel] [PATCH v2] tools: add option to explicitly enable VirtFS in QEMU build

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
> Sent: 11 September 2018 14:45
> To: Paul Durrant <Paul.Durrant@xxxxxxxxxx>
> Cc: Julien Grall <julien.grall@xxxxxxx>; Andrew Cooper
> <Andrew.Cooper3@xxxxxxxxxx>; Wei Liu <wei.liu2@xxxxxxxxxx>; George
> Dunlap <George.Dunlap@xxxxxxxxxx>; Ian Jackson <Ian.Jackson@xxxxxxxxxx>;
> Stefano Stabellini <sstabellini@xxxxxxxxxx>; xen-devel <xen-
> devel@xxxxxxxxxxxxxxxxxxxx>; Konrad Rzeszutek Wilk
> <konrad.wilk@xxxxxxxxxx>; Tim (Xen.org) <tim@xxxxxxx>
> Subject: Re: [PATCH v2] tools: add option to explicitly enable VirtFS in QEMU
> build
> 
> >>> On 11.09.18 at 15:37, <paul.durrant@xxxxxxxxxx> wrote:
> > 9pfs support has been a documented feature since Xen 4.9, but QEMU will
> > not be built with backend support unless VirtFS is enabled, which is
> > predicated on the libcap and libattr dev packages being installed. This is
> > not obvious to anyone intending to use 9pfs.
> >
> > This patch adds an 'enable-9pfs' option to configure which, if specified,
> > will cause '--enable-virtfs' to be passed to QEMU's configure. This will
> > cause the dependency on libcap and libattr to be called out if the packages
> > are not in installed.
> >
> > For completeness, specifying 'disable-9pfs' will cause '--disable-virtfs' to
> > be passed to QEMU's confgure and not specifying an option will keep the
> > previous behaviour of predicating VirtFS on whether the libcap and libattr
> > packages are installed.
> >
> > NOTE: The shell script in configure might look odd, but it is coded for
> >       consistency with other similar logic blocks within the file.
> >
> > Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> > ---
> > Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> > Cc: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>
> > Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> > Cc: Jan Beulich <jbeulich@xxxxxxxx>
> > Cc: Julien Grall <julien.grall@xxxxxxx>
> > Cc: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> > Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> > Cc: Tim Deegan <tim@xxxxxxx>
> > Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> >
> > v2:
> >  - Add the configure option rather then enabling VirtFS in all Linux builds.
> > ---
> >  config/Tools.mk.in |  1 +
> >  tools/Makefile     | 10 +++++++++-
> >  tools/configure    | 29 +++++++++++++++++++++++++++++
> >  3 files changed, 39 insertions(+), 1 deletion(-)
> 
> Wouldn't you first and foremost need to edit tools/configure.ac?
> 

No idea. There seem to be several layer of magic so it's quite believable that 
I've missed one. Any clue as to what I need to do there?

  Paul

> Jan
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel