Re: [Xen-devel] [PATCH] xen: Improvements to domain_crash()

[Dario Faggioli <dfaggioli@xxxxxxxx>]

On Thu, 2018-08-30 at 16:31 +0100, Andrew Cooper wrote:
> There original reason for this patch was to fix a livepatching
> problem;
> unnecesserily large livepatchs due to the use of __LINE__.
> 
> A second problem is one of debugability.  A number of domain_crash()
> invocations have no logging at all, and number of others only have
> logging
> when compiled with a debug hypervisor.
> 
> Change the interface to require the caller to pass a printk()
> message, which
> is emitted at guest error level.  This should ensure that every time
> a domain
> is crashed, an informative log message is also present.
> 
> Update all callers to either merge with a previous printk(), or
> invent an
> informative log message.  A few select callers are switched to the
> non-printing version, when they've already emitted a relevent state
> dump.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>
I like the idea, and the patch looks fine to me.

I don't think my Ack is really necessary. I see it's changing
xen/include/xen/sched.h but, AFAICT, that does not fall under the
schedulers' maintainers umbrella.

Anyway:

Reviewed-by: Dario Faggioli <dfaggioli@xxxxxxxx>

Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Software Engineer @ SUSE https://www.suse.com/

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel