Re: [Xen-devel] [PATCH v3 2/3] x86/viridan: Clean up Viridian MSR infrastructure

[Sergey Dyasli <sergey.dyasli@xxxxxxxxxx>]

On Tue, 2018-09-11 at 19:56 +0100, Andrew Cooper wrote:
> Rename the functions to guest_{rd,wr}msr_viridian() for consistency, and
> because the _regs() suffix isn't very appropriate.
> 
> Update them to take a vcpu pointer rather than presuming that they act on
> current, which is safe for all implemented operations, and switch their return
> ABI to use X86EMUL_*.
> 
> The default cases no longer need to deal with MSRs out of the Viridian range,
> but drop the printks to debug builds only and identify the value attempting to
> be written.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Reviewed-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> ---
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> CC: Wei Liu <wei.liu2@xxxxxxxxxx>
> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> CC: Sergey Dyasli <sergey.dyasli@xxxxxxxxxx>
> 
> v3:
>  * Clean up after splitting the series.  Retain appropriate R-by's
> ---
>  xen/arch/x86/hvm/viridian.c        | 46 
> ++++++++++++++------------------------
>  xen/arch/x86/msr.c                 |  6 ++---
>  xen/include/asm-x86/hvm/viridian.h | 11 ++-------
>  3 files changed, 21 insertions(+), 42 deletions(-)
> 

Reviewed-by: Sergey Dyasli <sergey.dyasli@xxxxxxxxxx>

-- 
Thanks,
Sergey
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel