Re: [Xen-devel] [PATCH 1/3] xen/vcpu: Rename the common interfaces for consistency

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Thu, Sep 06, 2018 at 08:25:32PM +0100, Andrew Cooper wrote:
> The vcpu functions are far less consistent than the domain side of things, and
> in particular, has vcpu_destroy() for architecture specific functionality.
> 
> Perform the following renames:
> 
>   * alloc_vcpu      => vcpu_create
>   * vcpu_initialise => arch_vcpu_create
>   * vcpu_destroy    => arch_vcpu_destroy
> 
> which makes the vcpu hierarchy consistent with the domain hierarchy.
> 
> No functional change.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

> diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h
> index 5593495..6df6a58 100644
> --- a/xen/include/xen/domain.h
> +++ b/xen/include/xen/domain.h
> @@ -13,7 +13,7 @@ typedef union {
>      struct compat_vcpu_guest_context *cmp;
>  } vcpu_guest_context_u __attribute__((__transparent_union__));
>  
> -struct vcpu *alloc_vcpu(
> +struct vcpu *vcpu_create(
>      struct domain *d, unsigned int vcpu_id, unsigned int cpu_id);
>  
>  unsigned int dom0_max_vcpus(void);
> @@ -47,13 +47,13 @@ void free_pirq_struct(void *);
>  
>  /*
>   * Initialise/destroy arch-specific details of a VCPU.
> - *  - vcpu_initialise() is called after the basic generic fields of the
> + *  - arch_vcpu_create() is called after the basic generic fields of the
>   *    VCPU structure are initialised. Many operations can be applied to the
>   *    VCPU at this point (e.g., vcpu_pause()).
> - *  - vcpu_destroy() is called only if vcpu_initialise() previously 
> succeeded.
> + *  - arch_vcpu_destroy() is called only if arch_vcpu_create() previously 
> succeeded.

Line is too long.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel