[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v3 11/16] x86/mm: put HVM only code under CONFIG_HVM
On Fri, Sep 07, 2018 at 03:27:37PM -0600, Tamas K Lengyel wrote: > On Tue, Sep 4, 2018, 10:29 AM Wei Liu <wei.liu2@xxxxxxxxxx> wrote: > > > Going through the code, HAP, EPT, PoD and ALTP2M depend on HVM code. > > Put these components under CONFIG_HVM. This further requires putting > > one of the vm event under CONFIG_HVM. > > > > Altp2m requires a bit more attention because its code is embedded in > > generic x86 p2m code. > > > > Also make hap_enabled evaluate to false when !CONFIG_HVM. Make sure it > > evaluate its parameter to avoid unused variable warnings in its users. > > > > Also sort items in Makefile while at it. > > > > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx> > > --- > > xen/arch/x86/mm/Makefile | 11 ++++++----- > > xen/arch/x86/mm/mem_access.c | 18 +++++++++++++++++- > > xen/arch/x86/mm/mem_sharing.c | 2 ++ > > xen/arch/x86/mm/p2m.c | 23 ++++++++++++----------- > > xen/common/vm_event.c | 2 ++ > > > > As before, please only apply CONFIG_HVM ifdefs to x86 specific parts. We > have an altp2m implementation for ARM that is planned to be posted again to > the mailinglist in the near future. I take that you are specifically talking about common/vm_event.c because that's the only common code here in the list of file. I have switched to provide a stub for p2m_altp2m_check in x86 header instead. Wei. > > Thanks, > Tamas _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |