|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v8 7/7] vtd: add lookup_page method to iommu_ops
>>> On 13.09.18 at 16:53, <Paul.Durrant@xxxxxxxxxx> wrote: >> From: Jan Beulich [mailto:JBeulich@xxxxxxxx] >> Sent: 13 September 2018 15:51 >> >> >>> On 13.09.18 at 16:04, <Paul.Durrant@xxxxxxxxxx> wrote: >> >> From: Jan Beulich [mailto:JBeulich@xxxxxxxx] >> >> Sent: 13 September 2018 14:57 >> >> >> >> >>> On 13.09.18 at 15:50, <Paul.Durrant@xxxxxxxxxx> wrote: >> >> > Ok. I'll spell it out in the header if you think it is non-obvious. >> >> >> >> Obvious or not - do we _have_ any such outer locking in place right >> now? >> >> >> > >> > Yes. The locking is either via the P2M or grant table locks for all >> current >> > uses or map and unmap that I can see. >> >> But two different locks still means no guarantees at all. >> > > So, are you saying the current implementation is not fit for purpose? Do you > want me to add locking at the wrapper level? Well, I haven't looked closely enough to be certain, but I'm afraid there might be an issue, and if so I certainly think it needs taking care of before widening the problem by exposing (more of it) to guests. Of course it may well be that addition of another locking layer may have adverse effects, to existing code and/or your additions. Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/xen-devel
|
 |
Lists.xenproject.org is hosted with RackSpace, monitoring our |