Re: [Xen-devel] [PATCH] Make credit2 the default scheduler

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Sep 14, 2018 at 02:45:35AM -0600, Jan Beulich wrote:
> >>> On 13.09.18 at 18:51, <dfaggioli@xxxxxxxx> wrote:
> > On Thu, 2018-09-13 at 17:38 +0100, George Dunlap wrote:
> >> Credit2 was declared "supported" in 4.8, and as of 4.10 had two other
> >> critical features implemented (soft affinity / NUMA and caps).
> >> 
> >> [..]
> >>
> >> Credit2, like credit, has a number of workloads / setups for which
> >> performance could be improved.  Personally I think networking and
> >> partially-loaded systems is going to be more representative of what
> >> Xen is actually used for; so I think credit2 is on the whole the
> >> better scheduler to use by default.  And in any case, making those
> >> improvements on credit2 will be easier than on credit.
> >> 
> >> Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxxx>
> >>
> > After all the effort we've spent on this, I'm really, really happy to
> > see this (trying to) happen. Thanks for sending the patch. :-)
> > 
> > I fully agree with and second George's reasoning, and feel 100% like
> > providing my:
> > 
> > Acked-by: Dario Faggioli <dfaggioli@xxxxxxxx>
> 
> And that's despite "sched=credit2 crashes system when using
> cpupools"? While I agree that we shouldn't delay the switch for

Urgh, this is a really nasty bug.

> much longer, in particular with there already being a fix available
> from you I think that one should go in before the one here.

+1.

Wei.

> 
> Jan
> 
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel