Re: [Xen-devel] [PATCH v3 14/16] x86: expose CONFIG_HVM

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Sep 14, 2018 at 02:07:42AM -0600, Jan Beulich wrote:
> >>> On 13.09.18 at 18:01, <wei.liu2@xxxxxxxxxx> wrote:
> > On Fri, Sep 07, 2018 at 01:15:05AM -0600, Jan Beulich wrote:
> >> >>> On 04.09.18 at 18:15, <wei.liu2@xxxxxxxxxx> wrote:
> >> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> >> > ---
> >> > v3: longer text
> >> > v2: use tab to indent
> >> > 
> >> > Haven't added a dependency on PV_SHIM_EXCLUSIVE because agreement is
> >> > not yet reached.
> >> 
> >> Hmm, but then I would have expected you to at least do the minimal
> >> agreed upon change (modifying that other option's default). Beyond
> >> that I'm afraid we're moving towards a dead end here.
> >> 
> > 
> > I extended the help text to address Andrew's comment. Other than that, I
> > didn't see an agreement on "other option's default". What did I miss?
> 
> I don't think there was disagreement on this minimal change (in fact
> iirc Andrew explicitly agreed to it [1]). What we can't seem to agree
> on is whether to add a "depends on !PV_SHIM_EXCLUSIVE" to HVM.
> 
> Jan
> 
> [1] https://lists.xenproject.org/archives/html/xen-devel/2018-08/msg02408.html
> 

Oh, then that's more or less what I said in v4 patch. I proposed

   def_bool y if !PV_SHIM_EXCLUSIVE

in the that patch as a compromise.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel