Re: [Xen-devel] [PATCH] x86/pvh: copy data from low 1MB to Dom0 physmap instead of mapping it

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Sep 17, 2018 at 12:34:19PM +0200, Roger Pau Monné wrote:
[...]
> > >  static __init void pvh_setup_e820(struct domain *d, unsigned long 
> > > nr_pages)
> > >  {
> > >      struct e820entry *entry, *entry_guest;
> > > @@ -420,16 +393,24 @@ static int __init pvh_setup_p2m(struct domain *d)
> > 
> > 
> > Somewhere above the hunk you modified, there is a comment saying "Memory
> > below 1MB is identity mapped". Don't you need to change that as well?
> > Otherwise first 1MB still 1:1 maps to 1MB machine memory in guest p2m.
> 
> Non-RAM regions are still identity mapped.

I see. Got confused because it said "memory".

May I suggest you update the comment a bit to be more precise, something
like:

/*
 * Region below 1MB is identity mapped here, but RAM below 1MB will be
 * populated later when processing E820 map.
 */

In any case, the code looks fine:

Reviewed-by: Wei Liu <wei.liu2@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel