Re: [Xen-devel] [PATCH v2] iommu: setup inclusive mappings before enabling iommu

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 14.09.18 at 15:58, <roger.pau@xxxxxxxxxx> wrote:
> Or else it can lead to freezes when enabling the iommu on certain
> Intel hardware:
> 
> [...]
> (XEN) ELF: addresses:
> (XEN)     virt_base        = 0xffffffff80000000
> (XEN)     elf_paddr_offset = 0x0
> (XEN)     virt_offset      = 0xffffffff80000000
> (XEN)     virt_kstart      = 0xffffffff81000000
> (XEN)     virt_kend        = 0xffffffff82953000
> (XEN)     virt_entry       = 0xffffffff8274e180
> (XEN)     p2m_base         = 0x8000000000
> (XEN)  Xen  kernel: 64-bit, lsb, compat32
> (XEN)  Dom0 kernel: 64-bit, PAE, lsb, paddr 0x1000000 -> 0x295300
> <freeze>
> 
> This restores the behavior before commit 66a9274cc3435 that changed
> the order and enabled the iommu without having the inclusive mappings
> setup.
> 
> Note that on AMD hardware the order is also changed to add inclusive
> mappings before adding any devices.
> 
> Reported-by: Dario Faggioli <dfaggioli@xxxxxxxx>
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

With the exception of the ARM aspect (because it's not
clear to me why the code removed from iommu_hwdom_init()
doesn't need to re-appear in ARM-specific code as well)
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel