[Xen-devel] Ping: [PATCH] x86: fix "xpti=" and "pv-l1tf=" yet again

["Jan Beulich" <JBeulich@xxxxxxxx>]

Ping?

>>> On 11.09.18 at 10:20, <JBeulich@xxxxxxxx> wrote:
>>>> On 29.08.18 at 14:36, <andrew.cooper3@xxxxxxxxxx> wrote:
>> On 21/08/18 11:44, Jan Beulich wrote:
>>> While commit 2a3b34ec47 ("x86/spec-ctrl: Yet more fixes for xpti=
>>> parsing") indeed fixed "xpti=dom0", it broke "xpti=no-dom0", in that
>>> this then became equivalent to "xpti=no".
>> 
>> That was accidental, but the end result is consistent with other options.
>> 
>> As with spec-ctrl, if someone wants to start making fine-grain control,
>> they should specify everything.  There is a reason why the
>> 
>> **WARNING: Any use of this option may interfere with heuristics.  Use
>> with extreme care.**
>> 
>> disclaimer exists.
> 
> I've looked again: Such a disclaimer does not exist for xpti= nor
> pv-l1tf=, and it shouldn't, as use of these options does not in fact
> interfere with any (other) heuristics (they're separate options for
> reasons beyond syntax issues that would result if they were folded
> into spec-ctrl= ).
> 
> If the sole remaining change request was to split the variables into
> separate booleans, I can do that (although, as said, I'm not
> convinced this is helpful). But there were other open points, and
> I'd prefer to either commit v1 with the one copy-and-paste bug
> fixed, or send a v2 which has a chance of being accepted (i.e.
> with all open points addressed verbally or by code changes).
> 
> Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel