Re: [Xen-devel] [PATCH v9 5/7] memory: add check_get_page_from_gfn() as a wrapper...

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 19.09.18 at 11:29, <roger.pau@xxxxxxxxxx> wrote:
> On Wed, Sep 19, 2018 at 03:22:54AM -0600, Jan Beulich wrote:
>> >>> On 19.09.18 at 10:54, <Paul.Durrant@xxxxxxxxxx> wrote:
>> >> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
>> >> Sent: 19 September 2018 09:34
>> >> 
>> >> >>> On 19.09.18 at 09:56, <Paul.Durrant@xxxxxxxxxx> wrote:
>> > Ok, if we include p2m-common in the middle of p2m, and then add stuff 
>> > dependent on the declaration of p2m_type_t, what happens when a source 
>> > module 
>> > explicitly includes p2m-common prior to p2m?
>> 
>> This is not supposed to happen, as this header is supposed to only be
>> included from the per-arch p2m.h; we should put an #error there. I
>> see there's exactly one violation of this (drivers/vpci/header.c). But
>> your series can go in as is; I'll try to remember to clean this up.
> 
> Oh, didn't know this, will send a patch to switch header.c to include
> p2m.h instead of p2m-common.h.

No need to, I've already made this part of the patch moving the
inclusion point.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel