Re: [Xen-devel] [PATCH v11 4/7] iommu: don't domain_crash() inside iommu_map/unmap_page()

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Sep 19, 2018 at 09:35:59AM +0100, Paul Durrant wrote:
> This patch removes the implicit domain_crash() from iommu_map(),
> unmap_page() and iommu_iotlb_flush() and turns them into straightforward
> wrappers that check the existence of the relevant iommu_op and call
> through to it. This makes them usable by PV IOMMU code to be delivered in
> future patches.
> This patch adds a helper macro, domu_crash(), that will only invoke
> domain_crash() if the domain is not the hardware domain and modifies
> callers of iommu_map(), unmap_page() and iommu_iotlb_flush() to use this
> should an operation fail.
> 
> NOTE: This patch includes one bit of clean-up in set_identity_p2m_entry()
>       replacing use of p2m->domain with the domain pointer passed into the
>       function.
> 
> Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>
> Reviewed-by: Roger Pau Monne <roger.pau@xxxxxxxxxx>

Reviewed-by: Wei Liu <wei.liu2@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel