Re: [Xen-devel] [PATCH v1] x86/hvm: Change return error for offline vcpus

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 20.09.18 at 14:54, <aisaila@xxxxxxxxxxxxxxx> wrote:
> --- a/xen/arch/x86/hvm/save.c
> +++ b/xen/arch/x86/hvm/save.c
> @@ -165,7 +165,7 @@ int hvm_save_one(struct domain *d, unsigned int typecode, 
> unsigned int instance,
>      if ( (rv = hvm_sr_handlers[typecode].save(v, &ctxt)) != 0 )
>          printk(XENLOG_G_ERR "HVM%d save: failed to save type %"PRIu16" 
> (%d)\n",
>                 d->domain_id, typecode, rv);
> -    else if ( rv = -ENOENT, ctxt.cur >= sizeof(*desc) )
> +    else if ( rv = -ENODATA, ctxt.cur >= sizeof(*desc) )

I think this change of error code should once again only be done
for HVMSR_PER_VCPU kind records. For the others no data
appearing is _the_ indication of the instance not existing.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel