[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH v2] ALSA: xen-front: Refine indentations and constify snd_pcm_ops



snd_pcm_ops are not supposed to change. So mark the
non-const structs as const. Also, refine indentation
to increase readability.

Signed-off-by: Nick Simonov <nicksimonovv@xxxxxxxxx>
---
Changes v2:
- Fix typo in commit description, ncrease to increase.

 sound/xen/xen_snd_front_alsa.c | 46 +++++++++++++++++++++---------------------
 1 file changed, 23 insertions(+), 23 deletions(-)

diff --git a/sound/xen/xen_snd_front_alsa.c b/sound/xen/xen_snd_front_alsa.c
index 129180e..2cbd967 100644
--- a/sound/xen/xen_snd_front_alsa.c
+++ b/sound/xen/xen_snd_front_alsa.c
@@ -637,31 +637,31 @@ static int alsa_pb_fill_silence(struct snd_pcm_substream 
*substream,
  * to know when the buffer can be transferred to the backend.
  */
 
-static struct snd_pcm_ops snd_drv_alsa_playback_ops = {
-       .open = alsa_open,
-       .close = alsa_close,
-       .ioctl = snd_pcm_lib_ioctl,
-       .hw_params = alsa_hw_params,
-       .hw_free = alsa_hw_free,
-       .prepare = alsa_prepare,
-       .trigger = alsa_trigger,
-       .pointer = alsa_pointer,
-       .copy_user = alsa_pb_copy_user,
-       .copy_kernel = alsa_pb_copy_kernel,
-       .fill_silence = alsa_pb_fill_silence,
+static const struct snd_pcm_ops snd_drv_alsa_playback_ops = {
+       .open           = alsa_open,
+       .close          = alsa_close,
+       .ioctl          = snd_pcm_lib_ioctl,
+       .hw_params      = alsa_hw_params,
+       .hw_free        = alsa_hw_free,
+       .prepare        = alsa_prepare,
+       .trigger        = alsa_trigger,
+       .pointer        = alsa_pointer,
+       .copy_user      = alsa_pb_copy_user,
+       .copy_kernel    = alsa_pb_copy_kernel,
+       .fill_silence   = alsa_pb_fill_silence,
 };
 
-static struct snd_pcm_ops snd_drv_alsa_capture_ops = {
-       .open = alsa_open,
-       .close = alsa_close,
-       .ioctl = snd_pcm_lib_ioctl,
-       .hw_params = alsa_hw_params,
-       .hw_free = alsa_hw_free,
-       .prepare = alsa_prepare,
-       .trigger = alsa_trigger,
-       .pointer = alsa_pointer,
-       .copy_user = alsa_cap_copy_user,
-       .copy_kernel = alsa_cap_copy_kernel,
+static const struct snd_pcm_ops snd_drv_alsa_capture_ops = {
+       .open           = alsa_open,
+       .close          = alsa_close,
+       .ioctl          = snd_pcm_lib_ioctl,
+       .hw_params      = alsa_hw_params,
+       .hw_free        = alsa_hw_free,
+       .prepare        = alsa_prepare,
+       .trigger        = alsa_trigger,
+       .pointer        = alsa_pointer,
+       .copy_user      = alsa_cap_copy_user,
+       .copy_kernel    = alsa_cap_copy_kernel,
 };
 
 static int new_pcm_instance(struct xen_snd_front_card_info *card_info,
-- 
2.7.4


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.