Re: [Xen-devel] [PATCH v2] x86/hvm: Change return error for offline vcpus

[Isaila Alexandru <aisaila@xxxxxxxxxxxxxxx>]

On Fri, 2018-09-21 at 09:44 +0100, Wei Liu wrote:
> On Fri, Sep 21, 2018 at 09:43:22AM +0100, Wei Liu wrote:
> > On Fri, Sep 21, 2018 at 10:30:30AM +0300, Alexandru Isaila wrote:
> > > This patch is needed in order to have a different return error
> > > for invalid vcpu
> > > and offline vcpu on the per vcpu king.
> > 
> > Sorry, I can't parse this sentence. What is "per vcpu king"?
> 
> Oh, "king" should be "kind".

Yes, king = kind, sorry for that  
> 
> > 
> > > 
> > > Signed-off-by: Alexandru Isaila <aisaila@xxxxxxxxxxxxxxx>
> > > 
> > > ---
> > > Changes since V1:
> > >   - Add conditional statement in order to have a difference
> > > between
> > >   per_vcpu and per_dom return error.
> > > ---
> > >  xen/arch/x86/hvm/save.c | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/xen/arch/x86/hvm/save.c b/xen/arch/x86/hvm/save.c
> > > index d520898843..1764fb0918 100644
> > > --- a/xen/arch/x86/hvm/save.c
> > > +++ b/xen/arch/x86/hvm/save.c
> > > @@ -165,7 +165,8 @@ int hvm_save_one(struct domain *d, unsigned
> > > int typecode, unsigned int instance,
> > >      if ( (rv = hvm_sr_handlers[typecode].save(v, &ctxt)) != 0 )
> > >          printk(XENLOG_G_ERR "HVM%d save: failed to save type
> > > %"PRIu16" (%d)\n",
> > >                 d->domain_id, typecode, rv);
> > > -    else if ( rv = -ENOENT, ctxt.cur >= sizeof(*desc) )
> > > +    else if ( rv = hvm_sr_handlers[typecode].kind ==
> > > HVMSR_PER_VCPU ?
> > > +              -ENODATA : -ENOENT, ctxt.cur >= sizeof(*desc) )
> > >      {
> > >          uint32_t off;
> > >  
> > > -- 
> > > 2.17.1
> > > 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel