Re: [Xen-devel] [PATCH v4 4/7] x86/mm: put HVM only code under CONFIG_HVM

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Sep 13, 2018 at 10:50:45AM -0600, Tamas K Lengyel wrote:
> > @@ -483,12 +495,15 @@ int p2m_get_mem_access(struct domain *d, gfn_t gfn, 
> > xenmem_access_t *access)
> >
> >  void arch_p2m_set_access_required(struct domain *d, bool access_required)
> >  {
> > +#ifdef CONFIG_HVM
> >      unsigned int i;
> > +#endif
> 
> Perhaps this would look a little nicer with a minor restructure so
> that there are no two ifdefs within this function..
> 
> >
> >      ASSERT(atomic_read(&d->pause_count));
> >
> >      p2m_get_hostp2m(d)->access_required = access_required;
> >
> > +#ifdef CONFIG_HVM
> >      if ( !altp2m_active(d) )
> 
> .. by changing this is into if ( altp2m_active(d) ) and moving the
> unsigned int i declaration afterwards. I understand however if you
> want to keep this patch mechanical.

Done.

> 
> >          return;
> >
> > @@ -499,6 +514,7 @@ void arch_p2m_set_access_required(struct domain *d, 
> > bool access_required)
> >          if ( p2m )
> >              p2m->access_required = access_required;
> >      }
> > +#endif
> >  }
> 
> So with or without that change:
> Acked-by: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>

Thanks.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel