Re: [Xen-devel] [OSSTEST PATCH] ts-xen-build-prep: install libgnutls28-dev for libvirt build

[Ian Jackson <ian.jackson@xxxxxxxxxx>]

Wei Liu writes ("[OSSTEST PATCH] ts-xen-build-prep: install libgnutls28-dev for 
libvirt build"):
> d54ecf31b2 placed the build dependency in a wrong file. This patch
> reverts it and adds the dependency to the right file.

Now that I look at this properly and at the context, I think that we
need to add a runtime dependency to libvirt.pm, here:

> diff --git a/Osstest/Toolstack/libvirt.pm b/Osstest/Toolstack/libvirt.pm
> index d5cda77e..45df1734 100644
> --- a/Osstest/Toolstack/libvirt.pm
> +++ b/Osstest/Toolstack/libvirt.pm
> @@ -26,7 +26,7 @@ use XML::LibXML;
>  
>  sub new {
>      my ($class, $ho, $methname,$asset) = @_;
> -    my @extra_packages = qw(libavahi-client3 libgnutls28-dev);
> +    my @extra_packages = qw(libavahi-client3);

Since if libvirt has gnutls as a build-dep some bit of it is probably
linked against it and will fail otherwise.  I think the right answer
is therefore
  +    my @extra_packages = qw(libavahi-client3 libgnutls30);
(in addition to the hunk in ts-xen-build-prep).

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel