[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 4/6] xen/arm: cpufeature: Add helper to check constant caps





On 30/08/18 18:43, Volodymyr Babchuk wrote:
Hi Julien,

Hi,

On 24.08.18 19:58, Julien Grall wrote:
Some capababilities are set right during boot and will never change
afterwards. At the moment, the function cpu_have_caps will check whether
the cap is enabled from the memory.

It is possible to avoid the load from the memory by using an
ALTERNATIVE. With that the check is just reduced to 1 instruction.

Signed-off-by: Julien Grall <julien.grall@xxxxxxx>

---

This is the static key for the poor. At some point we might want to
introduce something similar to static key in Xen.
---
  xen/include/asm-arm/cpufeature.h | 12 ++++++++++++
  1 file changed, 12 insertions(+)

diff --git a/xen/include/asm-arm/cpufeature.h b/xen/include/asm-arm/cpufeature.h
index 3de6b54301..9c297c521c 100644
--- a/xen/include/asm-arm/cpufeature.h
+++ b/xen/include/asm-arm/cpufeature.h
@@ -63,6 +63,18 @@ static inline bool cpus_have_cap(unsigned int num)
      return test_bit(num, cpu_hwcaps);
  }

+#include <asm/alternative.h>

I would rather not, alternative.h already includes cpufeature.h.

My preference would be the user of cpus_have_const_cap() to include alternative.h.

Cheers,



+/* System capability check for constant cap */
+#define cpus_have_const_cap(num) ({                 \
+        bool __ret;                                 \
+                                                    \
+        asm volatile (ALTERNATIVE("mov %0, #0",     \
+                                  "mov %0, #1",     \
+                                  num)              \
+                      : "=r" (__ret));              \
+                                                    \
+        __ret;                                      \
+        })
+
  static inline void cpus_set_cap(unsigned int num)
  {
      if (num >= ARM_NCAPS)



--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.