[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [xen-unstable test] 128240: regressions - FAIL


  • To: George Dunlap <george.dunlap@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wei.liu2@xxxxxxxxxx>
  • From: Juergen Gross <jgross@xxxxxxxx>
  • Date: Mon, 1 Oct 2018 18:07:26 +0200
  • Autocrypt: addr=jgross@xxxxxxxx; prefer-encrypt=mutual; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNHkp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmRlPsLAeQQTAQIAIwUCU4xw6wIbAwcL CQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJELDendYovxMvi4UH/Ri+OXlObzqMANruTd4N zmVBAZgx1VW6jLc8JZjQuJPSsd/a+bNr3BZeLV6lu4Pf1Yl2Log129EX1KWYiFFvPbIiq5M5 kOXTO8Eas4CaScCvAZ9jCMQCgK3pFqYgirwTgfwnPtxFxO/F3ZcS8jovza5khkSKL9JGq8Nk czDTruQ/oy0WUHdUr9uwEfiD9yPFOGqp4S6cISuzBMvaAiC5YGdUGXuPZKXLpnGSjkZswUzY d9BVSitRL5ldsQCg6GhDoEAeIhUC4SQnT9SOWkoDOSFRXZ+7+WIBGLiWMd+yKDdRG5RyP/8f 3tgGiB6cyuYfPDRGsELGjUaTUq3H2xZgIPfOwE0EU4xwFgEIAMsx+gDjgzAY4H1hPVXgoLK8 B93sTQFN9oC6tsb46VpxyLPfJ3T1A6Z6MVkLoCejKTJ3K9MUsBZhxIJ0hIyvzwI6aYJsnOew cCiCN7FeKJ/oA1RSUemPGUcIJwQuZlTOiY0OcQ5PFkV5YxMUX1F/aTYXROXgTmSaw0aC1Jpo w7Ss1mg4SIP/tR88/d1+HwkJDVW1RSxC1PWzGizwRv8eauImGdpNnseneO2BNWRXTJumAWDD pYxpGSsGHXuZXTPZqOOZpsHtInFyi5KRHSFyk2Xigzvh3b9WqhbgHHHE4PUVw0I5sIQt8hJq 5nH5dPqz4ITtCL9zjiJsExHuHKN3NZsAEQEAAcLAXwQYAQIACQUCU4xwFgIbDAAKCRCw3p3W KL8TL0P4B/9YWver5uD/y/m0KScK2f3Z3mXJhME23vGBbMNlfwbr+meDMrJZ950CuWWnQ+d+ Ahe0w1X7e3wuLVODzjcReQ/v7b4JD3wwHxe+88tgB9byc0NXzlPJWBaWV01yB2/uefVKryAf AHYEd0gCRhx7eESgNBe3+YqWAQawunMlycsqKa09dBDL1PFRosF708ic9346GLHRc6Vj5SRA UTHnQqLetIOXZm3a2eQ1gpQK9MmruO86Vo93p39bS1mqnLLspVrL4rhoyhsOyh0Hd28QCzpJ wKeHTd0MAWAirmewHXWPco8p1Wg+V+5xfZzuQY0f4tQxvOpXpt4gQ1817GQ5/Ed/wsDtBBgB CAAgFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAlrd8NACGwIAgQkQsN6d1ii/Ey92IAQZFggA HRYhBFMtsHpB9jjzHji4HoBcYbtP2GO+BQJa3fDQAAoJEIBcYbtP2GO+TYsA/30H/0V6cr/W V+J/FCayg6uNtm3MJLo4rE+o4sdpjjsGAQCooqffpgA+luTT13YZNV62hAnCLKXH9n3+ZAgJ RtAyDWk1B/0SMDVs1wxufMkKC3Q/1D3BYIvBlrTVKdBYXPxngcRoqV2J77lscEvkLNUGsu/z W2pf7+P3mWWlrPMJdlbax00vevyBeqtqNKjHstHatgMZ2W0CFC4hJ3YEetuRBURYPiGzuJXU pAd7a7BdsqWC4o+GTm5tnGrCyD+4gfDSpkOT53S/GNO07YkPkm/8J4OBoFfgSaCnQ1izwgJQ jIpcG2fPCI2/hxf2oqXPYbKr1v4Z1wthmoyUgGN0LPTIm+B5vdY82wI5qe9uN6UOGyTH2B3p hRQUWqCwu2sqkI3LLbTdrnyDZaixT2T0f4tyF5Lfs+Ha8xVMhIyzNb1byDI5FKCb
  • Cc: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Dario Faggioli <dario.faggioli@xxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, osstest service owner <osstest-admin@xxxxxxxxxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Mon, 01 Oct 2018 16:07:37 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Openpgp: preference=signencrypt

On 01/10/2018 17:48, George Dunlap wrote:
> On 10/01/2018 04:40 PM, Andrew Cooper wrote:
>> On 01/10/18 16:35, Wei Liu wrote:
>>> On Mon, Oct 01, 2018 at 04:19:07PM +0100, George Dunlap wrote:
>>>> On 10/01/2018 04:17 PM, Wei Liu wrote:
>>>>> On Mon, Oct 01, 2018 at 09:10:25AM -0600, Jan Beulich wrote:
>>>>>>>>> On 01.10.18 at 16:33, <wei.liu2@xxxxxxxxxx> wrote:
>>>>>>> On Mon, Oct 01, 2018 at 03:04:02AM -0600, Jan Beulich wrote:
>>>>>>>>>>> On 30.09.18 at 23:59, <osstest-admin@xxxxxxxxxxxxxx> wrote:
>>>>>>>>> flight 128240 xen-unstable real [real]
>>>>>>>>> http://logs.test-lab.xenproject.org/osstest/logs/128240/ 
>>>>>>>>>
>>>>>>>>> Regressions :-(
>>>>>>>>>
>>>>>>>>> Tests which did not succeed and are blocking,
>>>>>>>>> including tests which could not be run:
>>>>>>>>>  test-amd64-amd64-migrupgrade 22 guest-migrate/src_host/dst_host fail 
>>>>>>>>> REGR. vs. 
>>>>>>> 128084
>>>>>>>> At the first glance
>>>>>>>>
>>>>>>>> libxl: error: libxl_sched.c:232:sched_credit_domain_set: Domain 
>>>>>>>> 1:Getting 
>>>>>>> domain sched credit: Invalid argument
>>>>>>>> libxl: error: libxl_create.c:1275:domcreate_rebuild_done: Domain 
>>>>>>>> 1:cannot 
>>>>>>> (re-)build domain: -3
>>>>>>>> might indicate a problem resulting from the switch to credit2 as the 
>>>>>>>> default
>>>>>>>> scheduler. But "first glance" here really means what it says - I 
>>>>>>>> didn't look
>>>>>>>> (yet) at what exactly libxl tries to do there, in the hope that others 
>>>>>>>> may
>>>>>>>> know without much digging.
>>>>>>> I think this is due to toolstack trying to set the same scheduler
>>>>>>> parameters for the newly created guest.
>>>>>>>
>>>>>>> But in this test, the destination host is using a different scheduler
>>>>>>> from the source host. Asking for credit scheduler on a credit2 host is
>>>>>>> wrong.
>>>>>>>
>>>>>>> The relevant snippet in guest cfg (JSON) is:
>>>>>>>
>>>>>>>                 "sched_params": {
>>>>>>>                     "sched": "credit",
>>>>>>>                     "weight": 256,
>>>>>>>                     "cap": 0
>>>>>>>                 },
>>>>>>>
>>>>>>> I can't think of a method to fix it off the top of my head though.
>>>>>> So is this something that was specified in the original config? Or
>>>>>> is it just the current value which gets read and an attempt made
>>>>>> to re-install. If there was no explicit setting in the guest config,
>>>>>> shouldn't such a "default" setting be retained by not transferring
>>>>>> any scheduler specifics during migration?
>>>>>>
>>>>> No setting in guest cfg. Those values are extracted from the hypervisor.
>>>>> I think we may be able to not send default values to the remote end.
>>>> Wait, the migration code reads the scheduler parameters -- even if these
>>>> have not been explicitly set by the admin -- and sends them along with
>>>> the migration stream?  And if the remote scheduler is different, the
>>>> migration fails?
>>>>
>>>> That's not so good. :-)
>>> But one can argue that the guest is specific configured that way so it's
>>> parameters should be preserved. We normally analyse things on a case by
>>> case basis.
>>
>> If there isn't an obvious fix, then the switch of default scheduler
>> needs reverting until there is a fix present.  This is currently
>> blocking master.
> 
> Agreed.  I'd argue for ignoring failures to set scheduler parameters on
> migrate, on the grounds that this will be less risk to the project as a
> whole than reverting credit2 again.  But either way we should do
> something quickly.

We should ignore a mismatch of the scheduler. Failures when setting
parameters for a matching scheduler should not be ignored IMO.


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.