[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH 2/4] tools/xen-hvmctx: drop bogus casts from dump_lapic_regs()



The casts weren't even to the right type - all LAPIC registers are
32-bit (pairs/groups of registers may be combined to form larger logical
ones, but this is not visible in the given data representation).

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

--- a/tools/misc/xen-hvmctx.c
+++ b/tools/misc/xen-hvmctx.c
@@ -250,9 +250,9 @@ static void dump_lapic_regs(void)
     printf("    LAPIC registers:\n");
     for ( i = 0 ; i < 0x400 ; i += 32 )
     {
-        printf("          0x%4.4x: 0x%16.16llx   0x%4.4x: 0x%16.16llx\n",
-               i, *(unsigned long long *)&r.data[i], 
-               i + 16, *(unsigned long long *)&r.data[i + 16]);        
+        printf("          0x%03x: 0x%08" PRIx32 "   0x%03x: 0x%08" PRIx32 "\n",
+               i, *(uint32_t *)&r.data[i],
+               i + 16, *(uint32_t *)&r.data[i + 16]);
     }
 }
 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.