Re: [Xen-devel] [PATCH v4 01/12] x86: infrastructure to allow converting certain indirect calls to direct ones

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 02.10.18 at 15:55, <wei.liu2@xxxxxxxxxx> wrote:
> On Tue, Oct 02, 2018 at 04:12:08AM -0600, Jan Beulich wrote:
>> In a number of cases the targets of indirect calls get determined once
>> at boot time. In such cases we can replace those calls with direct ones
>> via our alternative instruction patching mechanism.
>> 
>> Some of the targets (in particular the hvm_funcs ones) get established
>> only in pre-SMP initcalls, making necessary a second passs through the
>> alternative patching code. Therefore some adjustments beyond the
>> recognition of the new special pattern are necessary there.
>> 
>> Note that patching such sites more than once is not supported (and the
>> supplied macros also don't provide any means to do so).
>> 
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> ---
>> v4: Extend / adjust comments.
> 
> Thanks, this makes it much easier to reason about the code.
> 
> I know there are comments about a macro, but they don't really affect
> the meat of this patch, so whether the macro is split out to a
> prerequisite patch or not:
> 
> Reviewed-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Thanks, this is much appreciated especially in that context.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel