Re: [Xen-devel] [PATCH 00/12] add per-domain and per-cpupool generic parameters

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Sep 27, 2018 at 07:58:39AM +0200, Juergen Gross wrote:
> On 21/09/18 10:52, Wei Liu wrote:
> > On Fri, Sep 21, 2018 at 07:23:23AM +0200, Juergen Gross wrote:
> >> On 20/09/18 18:06, Wei Liu wrote:
> >>> On Wed, Sep 19, 2018 at 07:58:50PM +0200, Juergen Gross wrote:
> >>>>
> >>>> Did you look into the patches, especially patch 10? The parameters set
> >>>> are all stored in domain config via libxl__arch_domain_save_config().
> >>>
> >>> No, I didn't.
> >>>
> >>> I think the general idea of what you do in patch 10 should work. However
> >>> I want to comment on the implementation.
> >>>
> >>> It appears that the implementation in patch 10 concatenates the new
> >>> settings to the old ones. It is not very nice imo.
> >>>
> >>> If for the life time of the domain you set X times the same parameter
> >>> you get a string of foo=bar1 foo=bar2 in the saved config file.
> >>>
> >>> There is probably a simple solution: make the parameter list in IDL a
> >>> key value list. You then update the list accordingly.
> >>
> >> The problem with that approach are parameters with sub-parameters:
> >>
> >> par=sub1=no,sub2=yes
> >> par=sub2=yes
> > 
> > That means the value type of the top level key value list should ideally
> > be another key value list. I do notice the limitation in the key value
> > list type: the value can only be string.
> > 
> > There is another way to solve this: further parse the sub-parameters.
> > This doesn't require any parameter specific knowledge and there are
> > already functions to split strings.
> 
> I don't think this will work for the general case. It might be that
> 
> par=no
> 
> will switch off all sub-parameters. How would you handle that?

Isn't that what it is supposed to do? Do you want par=no to not turn par
completely off but leave part(s) of par on? Then how do you turn par off
completely?

Wei.

> 
> I'm looking into a way to report the current parameter settings.
> 
> 
> Juergen
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel