Re: [Xen-devel] [PATCH v3 09/25] xen/arm: introduce bootcmdlines

[Julien Grall <julien.grall@xxxxxxx>]

Hi Stefano,

On 04/10/2018 00:11, Stefano Stabellini wrote:
> On Wed, 1 Aug 2018, Julien Grall wrote:
> > > +    {
> > > +        mod = &mods->cmdline[i];
> > > +        if ( mod->kind == kind )
> > > +            return mod;
> > > +    }
> > > +    return NULL;
> > > +}
> > > +
> > >    const char * __init boot_module_kind_as_string(bootmodule_kind kind)
> > >    {
> > >        switch ( kind )
> > > @@ -723,7 +732,7 @@ void __init start_xen(unsigned long boot_phys_offset,
> > >        /* Register Xen's load address as a boot module. */
> > >        xen_bootmodule = add_boot_module(BOOTMOD_XEN,
> > >                                 (paddr_t)(uintptr_t)(_start +
> > > boot_phys_offset),
> > > -                             (paddr_t)(uintptr_t)(_end - _start + 1),
> > > NULL);
> > > +                             (paddr_t)(uintptr_t)(_end - _start + 1));
> > >        BUG_ON(!xen_bootmodule);
> > >          xen_paddr = get_xen_paddr();
> > > diff --git a/xen/include/asm-arm/setup.h b/xen/include/asm-arm/setup.h
> > > index f1e4a3f..cb7da51 100644
> > > --- a/xen/include/asm-arm/setup.h
> > > +++ b/xen/include/asm-arm/setup.h
> > > @@ -35,6 +35,12 @@ struct bootmodule {
> > >        bootmodule_kind kind;
> > >        paddr_t start;
> > >        paddr_t size;
> > > +};
> > > +
> > > +#define DT_MAX_NAME 32
> > It might be useful to explain where 32 comes from.
> The limit is somewhat arbitrary. I'll explain in a comment.
Is it? I thought you got it from the specification (2.2.1 in [1]):

"Each node in the devicetree is named according to the following convention:

node-name@unit-address

The node-name component specifies the name of the node. It shall be 1 to 
31 characters in length and consist solely of characters from the set of 
characters in Table 2.1.
"

As the number does not take into account the unit-address, I would bump 
to 41 characters (8 digit for unit-address should be sufficient and 1 
for @).
Cheers,

[1] 
https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.2
--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel