Re: [Xen-devel] [PATCH v3 23/25] xen: support console_switching between Dom0 and DomUs on ARM

[Julien Grall <julien.grall@xxxxxxx>]

On 10/05/2018 10:25 AM, Julien Grall wrote:
> On 10/04/2018 10:52 PM, Stefano Stabellini wrote:
> > On Wed, 1 Aug 2018, Jan Beulich wrote:
> > > > > > On 01.08.18 at 01:28, <sstabellini@xxxxxxxxxx> wrote:
> > > > Today Ctrl-AAA is used to switch between Xen and Dom0. Extend the
> > > > mechanism to allow for switching between Xen, Dom0, and any of the
> > > > initial DomU created from Xen alongside Dom0 out of information 
> > > > provided
> > > > via device tree.
> > > >
> > > > Rename xen_rx to console_rx to match the new behavior.
> > > >
> > > > Clarify existing comment about "notify the guest", making it clear that
> > > > it is only about the hardware domain.
> > > >
> > > > Export a function named console_input_domain() to allow others to know
> > > > which domains has input at a given time.
> > > As always in such cases I don't think such functions should be added
> > > without any caller.
> > I'll add console_input_domain within an #if 0 and remove the #if 0 in
> > the following patch. If you are OK with it, the two patches can be
> > merged on commit (Julien already agreed to it.) They are separate only
> > to make them easier to review.
> Which two patches? I agreed to merge #24 and #22. Not #23. Merging the 3 
> of them is going to make a massive patch which is not going to help 
> understand patches after they get merged.
Thinking a bit more. Why does it need to be under #if 0 and then merging 
the 2 patches? There are nothing prevent a 2 line function to be moved 
from one patch to another.
Cheers.

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel