[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4 01/12] x86: infrastructure to allow converting certain indirect calls to direct ones


  • To: Jan Beulich <JBeulich@xxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Fri, 5 Oct 2018 15:49:17 +0100
  • Autocrypt: addr=andrew.cooper3@xxxxxxxxxx; prefer-encrypt=mutual; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA==
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wei.liu2@xxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, Julien Grall <julien.grall@xxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Fri, 05 Oct 2018 14:52:17 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Openpgp: preference=signencrypt

On 05/10/18 14:43, Jan Beulich wrote:
>>>> On 05.10.18 at 14:39, <andrew.cooper3@xxxxxxxxxx> wrote:
>> On 03/10/18 19:38, Andrew Cooper wrote:
>>> Finally, this series doesn't link with the default Debian toolchain.
>>>
>>> andrewcoop@andrewcoop:/local/xen.git/xen$ ld --version
>>> GNU ld (GNU Binutils for Debian) 2.25
>>>
>>> andrewcoop@andrewcoop:/local/xen.git/xen$ make -s build -j8 
>>> XEN_TARGET_ARCH=x86_64 KCONFIG_CONFIG=.config-release
>>>  __  __            _  _    _ ____                     _        _     _      
>>>  \ \/ /___ _ __   | || |  / |___ \    _   _ _ __  ___| |_ __ _| |__ | | ___ 
>>>   \  // _ \ '_ \  | || |_ | | __) |__| | | | '_ \/ __| __/ _` | '_ \| |/ _ \
>>>   /  \  __/ | | | |__   _|| |/ __/|__| |_| | | | \__ \ || (_| | |_) | |  __/
>>>  /_/\_\___|_| |_|    |_|(_)_|_____|   \__,_|_| |_|___/\__\__,_|_.__/|_|\___|
>>>                                                                             
>>> prelink.o:(.debug_aranges+0x3c94): relocation truncated to fit: R_X86_64_32 
>>> against `.debug_info'
>>> prelink.o:(.debug_info+0x225fa): relocation truncated to fit: R_X86_64_32 
>>> against `.debug_str'
>>> prelink.o:(.debug_info+0x22b57): relocation truncated to fit: R_X86_64_32 
>>> against `.debug_str'
>>> prelink.o:(.debug_info+0x1b92da): relocation truncated to fit: R_X86_64_32 
>>> against `.debug_str'
>>> prelink.o:(.debug_info+0x21e976): relocation truncated to fit: R_X86_64_32 
>>> against `.debug_str'
>>> prelink.o:(.debug_info+0x21ec31): relocation truncated to fit: R_X86_64_32 
>>> against `.debug_str'
>>> prelink.o:(.debug_info+0x21f03b): relocation truncated to fit: R_X86_64_32 
>>> against `.debug_str'
>>> prelink.o:(.debug_info+0x2b2ac3): relocation truncated to fit: R_X86_64_32 
>>> against `.debug_loc'
>>> prelink.o:(.debug_info+0x2b37f6): relocation truncated to fit: R_X86_64_32 
>>> against `.debug_str'
>>> prelink.o:(.debug_info+0x448fab): relocation truncated to fit: R_X86_64_32 
>>> against `.debug_str'
>>> prelink.o:(.debug_info+0x44b856): additional relocation overflows omitted 
>>> from the output
>>> ld: prelink.o: access beyond end of merged section (6617683)
>>> ld: prelink.o: access beyond end of merged section (6617630)
>>> ld: prelink.o: access beyond end of merged section (6617579)
>>> ld: prelink.o: access beyond end of merged section (6617558)
>>> ld: prelink.o: access beyond end of merged section (6617544)
>>> ld: prelink.o: access beyond end of merged section (6617605)
>>> ld: prelink.o: access beyond end of merged section (6617718)
>>> ld: prelink.o: access beyond end of merged section (6617570)
>>> ld: prelink.o: access beyond end of merged section (6617665)
>>> ld: prelink.o: access beyond end of merged section (6617671)
>>> ld: prelink.o: access beyond end of merged section (6617624)
>>> ld: prelink.o: access beyond end of merged section (6617748)
>>> ld: prelink.o: access beyond end of merged section (6617771)
>>> ld: prelink.o: access beyond end of merged section (6617592)
>>> ld: prelink.o: access beyond end of merged section (6617635)
>>> ld: prelink.o: access beyond end of merged section (6617652)
>>> ld: prelink.o: access beyond end of merged section (6617766)
>>> ld: prelink.o: access beyond end of merged section (6617742)
> Something along the lines of one or both of the above kinds I've
> happened to run into when using a gas producing compressed
> debug sections together with an objcopy which doesn't know
> about such section (iirc older objcopy silently dropped some
> section flag in this case).

I've tracked the issues down Olaf's DEBUG_INFO patch.  Having DEBUG_INFO
set when DEBUG is clear (which is the default for release builds)
results in this breakage.

Another diagnostic has come to light:

ld: Dwarf Error: found dwarf version '0', this reader only handles
version 2, 3 and 4 information.
prelink.o:(.debug_info+0x1bcee4): relocation truncated to fit:
R_X86_64_32 against `.debug_str'


>
>>> ld: prelink.o(.debug_info+0xc962ed): reloc against `.debug_loc': error 2
>>> Makefile:134: recipe for target '/local/xen.git/xen/xen-syms' failed
>>> make[2]: *** [/local/xen.git/xen/xen-syms] Error 1
>>> make[2]: *** Waiting for unfinished jobs....
>>> /local/xen.git/xen/.xen.efi.0s.S: Assembler messages:
>>> /local/xen.git/xen/.xen.efi.0s.S:21: Warning: value 0x7d2f80000544 
>>> truncated to 0x80000544
>>> /local/xen.git/xen/.xen.efi.0s.S:22: Warning: value 0x7d2f800008dc 
>>> truncated to 0x800008dc
>>> /local/xen.git/xen/.xen.efi.0s.S:23: Warning: value 0x7d2f800008de 
>>> truncated to 0x800008de
>>> /local/xen.git/xen/.xen.efi.0s.S:24: Warning: value 0x7d2f800008e3 
>>> truncated to 0x800008e3
>>> /local/xen.git/xen/.xen.efi.0s.S:25: Warning: value 0x7d2f80001086 
>>> truncated to 0x80001086
>>> /local/xen.git/xen/.xen.efi.0s.S:26: Warning: value 0x7d2f8000108a 
>>> truncated to 0x8000108a
>>> /local/xen.git/xen/.xen.efi.0s.S:27: Warning: value 0x7d2f8000108e 
>>> truncated to 0x8000108e
>>> /local/xen.git/xen/.xen.efi.0s.S:28: Warning: value 0x7d2f800010dc 
>>> truncated to 0x800010dc
>>> /local/xen.git/xen/.xen.efi.0s.S:29: Warning: value 0x7d2f80001172 
>>> truncated to 0x80001172
>>> /local/xen.git/xen/.xen.efi.1s.S: Assembler messages:
>>> /local/xen.git/xen/.xen.efi.1s.S:21: Warning: value 0x7d2f80000544 
>>> truncated to 0x80000544
>>> /local/xen.git/xen/.xen.efi.1s.S:22: Warning: value 0x7d2f800008dc 
>>> truncated to 0x800008dc
>>> /local/xen.git/xen/.xen.efi.1s.S:23: Warning: value 0x7d2f800008de 
>>> truncated to 0x800008de
>>> /local/xen.git/xen/.xen.efi.1s.S:24: Warning: value 0x7d2f800008e3 
>>> truncated to 0x800008e3
>>> /local/xen.git/xen/.xen.efi.1s.S:25: Warning: value 0x7d2f80001086 
>>> truncated to 0x80001086
>>> /local/xen.git/xen/.xen.efi.1s.S:26: Warning: value 0x7d2f8000108a 
>>> truncated to 0x8000108a
>>> /local/xen.git/xen/.xen.efi.1s.S:27: Warning: value 0x7d2f8000108e 
>>> truncated to 0x8000108e
>>> /local/xen.git/xen/.xen.efi.1s.S:28: Warning: value 0x7d2f800010dc 
>>> truncated to 0x800010dc
>>> /local/xen.git/xen/.xen.efi.1s.S:29: Warning: value 0x7d2f80001172 
>>> truncated to 0x80001172
> These are just warnings, and I vaguely recall looking into this once (I
> don't see these myself, so I supposed I had asked you or someone
> else to send my some object files), finding that gas is right to warn,
> but the effect on the embedded symbol table should be benign. What
> I don't understand though is why I've never seen these myself.

This happens when you've got CONFIG_LIVEPATCH enabled and use the
default debian toolchain.

>
>>> Makefile:136: recipe for target '/local/xen.git/xen/xen' failed
>>> make[1]: *** [/local/xen.git/xen/xen] Error 2
>>> Makefile:45: recipe for target 'build' failed
>>> make: *** [build] Error 2
>>>
>>> Using LD 2.30 built from source is fine, but I'm not sure exactly what
>>> is going on here.
>> Actually, I've just encountered this failure to link on staging as well,
>> so it is clearly not related to this series.  Sorry for the noise (but
>> I'm still non-the-wiser as to what is actually broken).
> Could you try 2.31.1? Of course I did use 2.30 until 2.31 went out,
> and still didn't see this. Yet then again my variant is not exactly
> vanilla.

I could (when I've got time to recompile my non-default compilers), but
what is this going to demonstrate?  I wouldn't expect 2.31 to be broken
when 2.30 works fine.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.