Re: [Xen-devel] [PATCH 04/17] x86: introduce is_pv_64bit_{vcpu, domain}

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 04.10.18 at 17:43, <wei.liu2@xxxxxxxxxx> wrote:
> This is useful to rewrite the following pattern (v is PV vcpu)
> 
>    if ( is_pv_32bit_vcpu(v) )
>        do_foo;
>    else
>        do_bar;
> 
> to
> 
>    if ( is_pv_32bit_vcpu(v) )
>        do_foo;
>    else if ( is_pv_64bit_vcpu(v) )
>        do_bar;
>    else
>        ASSERT_UNREACHABLE;
> .
> 
> Previously it is not possible to rely on DCE to eliminate the do_bar
> part. It becomes possible with the new code structure.
> 
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Provided the additions go inside the #ifdef-s mentioned for patch 3
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel