Re: [Xen-devel] [PATCH 10/17] x86: provide stub for switch_compat

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Oct 12, 2018 at 08:33:48AM -0600, Jan Beulich wrote:
> >>> On 04.10.18 at 17:43, <wei.liu2@xxxxxxxxxx> wrote:
> > --- a/xen/include/xen/compat.h
> > +++ b/xen/include/xen/compat.h
> > @@ -228,7 +228,16 @@ struct vcpu_runstate_info;
> >  void xlat_vcpu_runstate_info(struct vcpu_runstate_info *);
> >  
> >  struct domain;
> > +
> > +#ifdef CONFIG_PV
> >  int switch_compat(struct domain *);
> > +#else
> > +# include <xen/errno.h>
> > +static inline int switch_compat(struct domain *d)
> > +{
> > +    return -EINVAL;
> > +}
> > +#endif
> 
> I see two options here: Either we go with th above, but with -EACCES
> as the return value (to match the current one for HVM domains), or
> the #ifdef goes around the case block in domctl.c. Personally I'd prefer
> the latter.

This makes me chuckle because originally I opted for what you want here
but decided to switch to using stub before posting.

I will do that in the next version of this series.

Wei.

> 
> Jan
> 
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel