Re: [Xen-devel] [PATCH v2 5/5] x86: Reorganise and rename debug register fields in struct vcpu

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Mon, Oct 15, 2018 at 03:07:21PM +0100, Andrew Cooper wrote:
> On 15/10/18 14:56, Roger Pau Monné wrote:
> > On Mon, Oct 15, 2018 at 11:36:20AM +0100, Andrew Cooper wrote:
> >> diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c
> >> +
> >>      /* data breakpoint extension MSRs */
> >>      uint32_t dr_mask[4];
> >>  
> >> @@ -567,7 +573,10 @@ struct arch_vcpu
> >>      void              *fpu_ctxt;
> >>      unsigned long      vgc_flags;
> >>      struct cpu_user_regs user_regs;
> >> -    unsigned long      debugreg[8];
> >> +
> >> +    /* Debug registers. */
> >> +    unsigned long dr[4], dr7;
> >> +    unsigned int dr6;
> > I'm likely missing some information here because I don't get why dr6
> > is 32bits while dr7 is 64bits wide. According to the spec the high
> > part (bits 63-32) on both registers is reserved, so I think it would
> > make more sense to use the same type for both.
> 
> dr7 would ideally be 32 bits wide, but __vmread() uses unsigned long *.

Just saw your reply to Boris, makes sense.

Thanks.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel