Re: [Xen-devel] [PATCH 15/17] x86: expose CONFIG_PV

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Oct 12, 2018 at 09:16:42AM -0600, Jan Beulich wrote:
> >>> On 04.10.18 at 17:43, <wei.liu2@xxxxxxxxxx> wrote:
> > --- a/xen/arch/x86/Kconfig
> > +++ b/xen/arch/x86/Kconfig
> > @@ -37,6 +37,14 @@ source "arch/Kconfig"
> >  
> >  config PV
> >     def_bool y
> > +   prompt "PV support"
> > +   ---help---
> > +     Interfaces to support PV guests which don't require hardware
> > +     support like Intel's VT-x or AMD's SVM.
> > +
> > +     This option is needed if you want to run PV guests.
> 
> We've had a discussion with (iirc) George and perhaps a few others
> about "guest" vs "domain", and I've learned that generally the
> former is meant to exclude Dom0 while the latter would include it.
> In that light either s/guest/domain/ for the help text, or please add
> explicit mention of Dom0 there (as PV is still the prevailing kind of
> Dom0, and you wouldn't want to trip people into disabling this just
> because they only run HVM guests).

I will change "guest" to "domain". On the same note the text for HVM
should be changed, too.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel