Re: [Xen-devel] [PATCH v4 20/23] xen: support console_switching between Dom0 and DomUs on ARM

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 20.10.18 at 01:10, <sstabellini@xxxxxxxxxx> wrote:
> On Mon, 8 Oct 2018, Jan Beulich wrote:
>> >>> On 05.10.18 at 20:47, <sstabellini@xxxxxxxxxx> wrote:
>> > @@ -391,31 +394,73 @@ static void dump_console_ring_key(unsigned char key)
>> >      free_xenheap_pages(buf, order);
>> >  }
>> >  
>> > -/* CTRL-<switch_char> switches input direction between Xen and DOM0. */
>> > +/*
>> > + * CTRL-<switch_char> switches input direction between Xen, Dom0 and
>> > + * DomUs.
>> > + */
>> 
>> Just like the title, this comment makes it sound as if any DomU could
>> participate in this switching.
> 
> Is the following any better?
> 
>   CTRL-<switch_char> changes input direction, rotating among Xen, Dom0, and 
> DomUs.
> 
> Otherwise please suggest your favorite wording and I'll use it.

"..., and the <whatever-term-you-mean-to-us-for-boot-time-
created-ones> DomUs"

>> > +    {
>> > +        /* Deliver input to hardware domain, unless it is already full. */
>> 
>> Looks like you've mis-edited the original comment.
> 
> I take that you mean that the word "buffer" is missing, right? It should
> be:
> 
>   Deliver input to the hardware domain buffer, unless it is already full.

Yes, thanks.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel