Re: [Xen-devel] [PATCH] CONFIG_XEN_PV breaks xen_create_contiguous_region on ARM

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Fri, 26 Oct 2018, Juergen Gross wrote:
> On 16/10/2018 10:38, Stefano Stabellini wrote:
> > xen_create_contiguous_region has now only an implementation if
> > CONFIG_XEN_PV is defined. However, on ARM we never set CONFIG_XEN_PV but
> > we do have an implementation of xen_create_contiguous_region which is
> > required for swiotlb-xen to work correctly (although it just sets
> > *dma_handle).
> > 
> > This fixes a bug introduced by 16624390816c4c40df3d777b34665d3fd01e693d.
> > 
> > diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
> > index fd18c97..939a962 100644
> > --- a/include/xen/xen-ops.h
> > +++ b/include/xen/xen-ops.h
> > @@ -41,7 +41,7 @@ static inline uint32_t xen_vcpu_nr(int cpu)
> >  
> >  extern unsigned long *xen_contiguous_bitmap;
> >  
> > -#ifdef CONFIG_XEN_PV
> > +#ifdef CONFIG_XEN_PV || CONFIG_ARM || CONFIG_ARM64
> >  int xen_create_contiguous_region(phys_addr_t pstart, unsigned int order,
> >                             unsigned int address_bits,
> >                             dma_addr_t *dma_handle);
> > 
> > 
> 
> Could you please test your patch before sending? It doesn't even compile
> without warning and it is missing SoB, correct "Fixes:" tag and looks as
> if it has been assembled by hand instead of using a proper tool like
> "git format-patch" (no "---" delimiter, extra empty lines at the end).

Sorry Juergen, I must have been distracted or maybe I was working on an
older version. Anyway, I'll send a new patch, rebased on master.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel