Re: [Xen-devel] [PATCH RFC] VMX: fix vmx_handle_eoi()

["Tian, Kevin" <kevin.tian@xxxxxxxxx>]

> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
> Sent: Thursday, October 25, 2018 5:46 PM
> 
> >>> On 19.10.18 at 16:30, <chao.gao@xxxxxxxxx> wrote:
> > On Fri, Oct 12, 2018 at 03:32:59AM -0600, Jan Beulich wrote:
> >>In commit 303066fdb1e ("VMX: fix interaction of APIC-V and Viridian
> >>emulation") I screwed up quite heavily: Instead of clearing SVI, RVI was
> >>cleared. Furthermore, unconditional clearing of SVI is wrong too - other
> >>ISR bits should be taken into account.
> >>
> >>Introduce a new helper set_svi(), split out of vmx_process_isr(), and
> >>use it also from vmx_handle_eoi().
> >>
> >>Following the problems in vmx_intr_assist() (see the still present big
> >>block of debugging code there) also warn (once) if EOI'd vector and
> >>original SVI don't match.
> >>
> >>Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> >
> > After correcting the description in the first paragraph
> >
> > Reviewed-by: Chao Gao <chao.gao@xxxxxxxxx>
> 
> With this - any chance of getting the necessary acks? Or
> am I expected to re-submit with the (already) adjusted
> description?
> 

Acked-by: Kevin Tian <kevin.tian@xxxxxxxxx>. Please fix the
description when committing. 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel