Re: [Xen-devel] [PATCH] use consistent values when consuming runtime-changeable parameters

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Oct 30, 2018 at 10:28:21AM -0600, Jan Beulich wrote:
> >>> On 30.10.18 at 17:23, <wei.liu2@xxxxxxxxxx> wrote:
> > On Tue, Oct 30, 2018 at 08:44:20AM -0600, Jan Beulich wrote:
> >> There's no guarantee that e.g. a switch() control expression's memory
> >> operand(s) get(s) read just once. Guard against the compiler producing
> >> "unexpected" code by sprinkling around some ACCESS_ONCE().
> >> 
> >> I'm leaving alone opt_conswitch[]: It gets accessed in quite a few
> >> places anyway, and an intermediate change won't have any severe effect
> >> afaict.
> >> 
> >> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> > 
> > I'm curious how you came up with the list of parameters that need
> > fixing.
> 
> I've just gone through all that are currently run-time changable.

Fair enough.

Reviewed-by: Wei Liu <wei.liu2@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel