Re: [Xen-devel] [PATCH V3 3/3] x86/altp2m: fix display frozen when switching to a new view early

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Oct 30, 2018 at 10:25:20AM -0600, Jan Beulich wrote:
> >>> On 29.10.18 at 13:40, <rcojocaru@xxxxxxxxxxxxxxx> wrote:
> > @@ -316,6 +339,22 @@ void p2m_memory_type_changed(struct domain *d)
> >      }
> >  }
> >  
> > +void p2m_memory_type_changed(struct domain *d)
> > +{
> > +    _memory_type_changed(p2m_get_hostp2m(d));
> > +
> > +#ifdef CONFIG_HVM
> > +    if ( unlikely(altp2m_active(d)) )
> > +    {
> > +        unsigned int i;
> > +
> > +        for ( i = 0; i < MAX_ALTP2M; i++ )
> > +            if ( d->arch.altp2m_eptp[i] != mfn_x(INVALID_MFN) )
> > +                _memory_type_changed(d->arch.altp2m_p2m[i]);
> > +    }
> > +#endif
> > +}
> 
> Hmm, I'm puzzled by the #ifdef placement. Wei, didn't we settle that
> this code is HVM only altogether?

Its callers live in hvm/mtrr.c which don't get built when HVM is
disabled. We rely on DCE to purge this function when linking.

With the introduction of altp2m fields in this function it may now be
better to put the whole function under CONFIG_HVM.

Wei.

> 
> Jan
> 
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel