Re: [Xen-devel] [PATCH v8 3/8] libxl: support mapping static shared memory areas during domain creation

[Julien Grall <julien.grall@xxxxxxx>]

On 10/30/18 3:36 PM, Ian Jackson wrote:
> Stefano Stabellini writes ("[PATCH v8 3/8] libxl: support mapping static shared 
> memory areas during domain creation"):
> > +_hidden
> > +bool libxl__arch_domain_support_sshm(const libxl_domain_build_info *b_info);
> > +
> > +_hidden
> > +int libxl__arch_domain_sshm_cachepolicy_setdefault(libxl_static_shm *sshm);
> > +
> >   #if defined(__i386__) || defined(__x86_64__)
> >   
> >   #define LAPIC_BASE_ADDRESS  0xfee00000
> > diff --git a/tools/libxl/libxl_arm.c b/tools/libxl/libxl_arm.c
> > index 25dc3de..054ad58 100644
> > --- a/tools/libxl/libxl_arm.c
> > +++ b/tools/libxl/libxl_arm.c
> > @@ -1138,6 +1138,21 @@ void libxl__arch_domain_build_info_setdefault(libxl__gc 
> > *gc,
> >       libxl_domain_build_info_init_type(b_info, LIBXL_DOMAIN_TYPE_PVH);
> >   }
> >   
> > +bool libxl__arch_domain_support_sshm(const libxl_domain_build_info *b_info)
> > +{
> > +    return true;
> > +}
> > +
> > +int libxl__arch_domain_sshm_cachepolicy_setdefault(libxl_static_shm *sshm)
> > +{
> > +    if (sshm->cache_policy == LIBXL_SSHM_CACHEPOLICY_UNKNOWN)
> > +        sshm->cache_policy = LIBXL_SSHM_CACHEPOLICY_ARM_NORMAL;
> > +    if (sshm->cache_policy >= LIBXL_SSHM_CACHEPOLICY_X86_NORMAL)
> > +        return ERROR_INVAL;
> This cache policy stuff is odd.  I couldn't see it being used by the
> hypervisor.  Why is it even there ?
We decided to not implement them in the hypervisor yet but still provide 
the xl interface for it. Would there be any issue to extern the 
interface later on?
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel