Re: [Xen-devel] [PATCH v2 6/9] viridian: separate time related enlightenment implementations...

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Oct 31, 2018 at 12:43:32PM +0000, Paul Durrant wrote:
> ...into new 'time' module.
> 
> This patch reduces the size of the main viridian source module by
> moving time related enlightenments into their own source module. This is
> done in anticipation of implementation of more such enightenments and
> a desire to not further lengthen the main source module when this work
> is done.
> 
> While moving the code:
> 
> - Move the declaration of HV_REFERENCE_TSC_PAGE from the header file into
>   the new source module, since it is only used there.
> - Clean up a bool_t.
> 
> Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
[...]
> +int viridian_time_wrmsr(struct vcpu *v, uint32_t idx, uint64_t val)
> +{
> +    struct domain *d = v->domain;
> +
> +    switch ( idx )
> +    {
> +    case HV_X64_MSR_REFERENCE_TSC:
> +        if ( !(viridian_feature_mask(d) & HVMPV_reference_tsc) )
> +            return X86EMUL_EXCEPTION;
> +
> +        d->arch.hvm.viridian.reference_tsc.raw = val;
> +        dump_reference_tsc(d);
> +        if ( d->arch.hvm.viridian.reference_tsc.fields.enabled )
> +            update_reference_tsc(d, true);
> +        break;
> +
> +    default:
> +        gdprintk(XENLOG_INFO,
> +                 "%s: unimplemented MSR %#x (%016"PRIx64")\n",

I believe this can fit into previous line just fine.

Anyway, don't let this minor block this patch.

Reviewed-by: Wei Liu <wei.liu2@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel