Re: [Xen-devel] [PATCH v1 1/6] x86/vvmx: introduce vvmcx_valid()

["Tian, Kevin" <kevin.tian@xxxxxxxxx>]

> From: Sergey Dyasli [mailto:sergey.dyasli@xxxxxxxxxx]
> Sent: Tuesday, October 30, 2018 8:41 PM
> 
> On 30/10/2018 07:41, Tian, Kevin wrote:
> >> From: Sergey Dyasli [mailto:sergey.dyasli@xxxxxxxxxx]
> >> Sent: Friday, October 12, 2018 11:28 PM
> >>
> >> As a convenient helper function and refactor the code to use it.
> >>
> >> No functional change.
> >>
> >> Signed-off-by: Sergey Dyasli <sergey.dyasli@xxxxxxxxxx>
> >
> > since vmcx is hvm abstracted term, what about using this
> > helper in svm side too?
> 
> I couldn't find any code in nestedsvm.c that would benefit from this new
> helper.
> 

just a quick check:

    if (nv->nv_vvmcx != NULL && nv->nv_vvmcxaddr != vmcbaddr) {
        ASSERT(nv->nv_vvmcxaddr != INVALID_PADDR);
        hvm_unmap_guest_frame(nv->nv_vvmcx, 1);
        nv->nv_vvmcx = NULL;
        nv->nv_vvmcxaddr = INVALID_PADDR;
    }

Thanks
Kevin
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel