[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v1] x86/hvm: Clean up may_defer from hvm_* helpers

>>> Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx> 11/01/18 3:04 PM >>>
>On 11/1/18 3:58 PM, Jan Beulich wrote:
>>>>> Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx> 11/01/18 11:31 AM >>>
>>> On 10/30/18 8:19 AM, Tian, Kevin wrote:
>>>>> From: Alexandru Stefan ISAILA [mailto:aisaila@xxxxxxxxxxxxxxx]
>>>>> Sent: Wednesday, October 24, 2018 5:19 PM
>>>>> The may_defer var was left with the older bool_t type. This patch
>>>>> changes the type to bool.
>>>>> Signed-off-by: Alexandru Isaila <aisaila@xxxxxxxxxxxxxxx>
>>>> Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>
>>> I think this trivial patch has all the acks it needs to go in?
>> It being trivial, I was considering to ignore the need for Paul's ack in this
>> case (which iirc has not been given so far), but since you ask - did you
>> check before asking? I can only re-iterate that generally it is the submitter
>> to chase acks, not any of the potential committers.
>Sorry, I was not aware Paul's ack was still needed. By check, do you
>mean take the recipients list (that I have from get_maintainer.pl) and
>match it to the MAINTAINERS file to see if there's no ack from any
>particular subcategory?

"Check" means by whatever approach you prefer, but yes, ultimately it
would be to compare against what ./MAINTAINERS has to say for every
one of the files changed in a patch. You'd then notice that a basic x86
ack is missing too, but I'm certainly in the position to deal with that if
everything else was ready for committing.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.