Re: [Xen-devel] [RFC PATCH v2 07/17] libxl: add save/restore support for qemu-xen in stubdomain

[Ian Jackson <ian.jackson@xxxxxxxxxx>]

Marek Marczykowski-Górecki writes ("Re: [RFC PATCH v2 07/17] libxl: add 
save/restore support for qemu-xen in stubdomain"):
> On Thu, Nov 01, 2018 at 05:11:21PM +0000, Ian Jackson wrote:
> > I think this hardcoded fd is troublesome.  For example, we don't have
> > anywhere to write down the list of hardcoded fds being used like this.
> > I mean, libxl and the Linux qemu stubdom wrapper script are allowed to
> > cooperate, but at least this needs a clear comment in the wrapper
> > script, and a reference here to the in-tree location of the script.
> 
> This is exactly what I'm writing about in cover letter. And indeed some
> #define would be helpful here.

Oh.  I see, the script isn't in this series.  It's in your separate
git repo.  I see now.  I think a reference to the document is more
important than a #define.

> > I'm missing the code which is transfers the data from the
> > state->saved_state to the console.  Am I just being dim ?
> 
> This is done by existing code by connecting STUBDOM_CONSOLE_RESTORE to
> that file. See libxl_dm.c:spawn_stub_launch_dm.

Ah.  Right.

TBH I feel I am not giving you a very high quality of review.  I seem
to be a bit dim today.  My apologies if this is frustrating for you.
But I didn't want to let all of this sit any longer.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel