Re: [Xen-devel] [PATCH v2 7/9] viridian: define type for the 'virtual VP assist page'

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
> Sent: 05 November 2018 13:00
> To: Paul Durrant <Paul.Durrant@xxxxxxxxxx>
> Cc: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>; Wei Liu
> <wei.liu2@xxxxxxxxxx>; xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
> Subject: Re: [PATCH v2 7/9] viridian: define type for the 'virtual VP
> assist page'
> 
> >>> On 31.10.18 at 13:43, <paul.durrant@xxxxxxxxxx> wrote:
> > --- a/xen/include/asm-x86/hvm/viridian.h
> > +++ b/xen/include/asm-x86/hvm/viridian.h
> > @@ -92,7 +92,7 @@ struct viridian_vcpu
> >  {
> >      struct {
> >          union viridian_page_msr msr;
> > -        void *va;
> > +        void *ptr;
> 
> Why void rather than the actual type? You can't use the typedef
> (for it being local to the .c file), but you can use the union tag
> here in a forward declaring manner.
> 

Ok. I'll have a look at that.

  Paul

> Jan
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel