Re: [Xen-devel] [PATCH v2 6/9] viridian: separate time related enlightenment implementations...

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 05.11.18 at 14:26, <Paul.Durrant@xxxxxxxxxx> wrote:
>> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
>> Sent: 05 November 2018 12:57
>> 
>> >>> On 31.10.18 at 13:43, <paul.durrant@xxxxxxxxxx> wrote:
>> > --- /dev/null
>> > +++ b/xen/arch/x86/hvm/viridian/time.c
>> > @@ -0,0 +1,245 @@
>> >
>> +/************************************************************************
>> **
>> > *
>> > + * time.c
>> > + *
>> > + * An implementation of some time related Viridian enlightenments.
>> > + * See Microsoft's Hypervisor Top Level Functional Specification.
>> > + * for more information.
>> > + */
>> > +
>> > +#include <xen/domain_page.h>
>> > +#include <xen/hypercall.h>
>> > +#include <xen/sched.h>
>> > +#include <xen/version.h>
>> > +
>> > +#include <asm/apic.h>
>> > +#include <asm/hvm/support.h>
>> > +
>> > +typedef struct _HV_REFERENCE_TSC_PAGE
>> > +{
>> > +    uint32_t TscSequence;
>> > +    uint32_t Reserved1;
>> > +    uint64_t TscScale;
>> > +    int64_t  TscOffset;
>> > +    uint64_t Reserved2[509];
>> > +} HV_REFERENCE_TSC_PAGE, *PHV_REFERENCE_TSC_PAGE;
>> 
>> And you want to continue to have it all upper case, despite us normally
>> using such identifiers for #define-s only?
>> 
> 
> It's a definition lifted from the spec. so it's usual Microsoft style... 
> i.e. upper case types and camel-case names. I didn't define UINT32, INT64 and 
> UINT64 types - as used by the spec - but I could do so if you'd prefer the 
> consistency.

Oh, no, I'm not looking forward to see UINT<n> appear. I
was rather asking whether the odd all-upper-case naming
could be changed, to be in line with our style rather than
Microsoft's.

>> Apart from that same remark regarding the placement of the function
>> declarations as for the previous patch.
> 
> I assume you mean in the proposed new header, which is fine.

Yes, that's what I mean.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel