Re: [Xen-devel] [PATCH v3 3/7] x86: make PV hypercall entry points work with !CONFIG_PV

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 02.11.18 at 16:55, <wei.liu2@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/x86_64/traps.c
> +++ b/xen/arch/x86/x86_64/traps.c
> @@ -298,8 +298,21 @@ static unsigned int write_stub_trampoline(
>  }
>  
>  DEFINE_PER_CPU(struct stubs, stubs);
> +
> +#ifdef CONFIG_PV
>  void lstar_enter(void);
>  void cstar_enter(void);
> +#else
> +static inline void lstar_enter(void)
> +{
> +    panic("%s called", __func__);
> +}
> +
> +static inline void cstar_enter(void)
> +{
> +    panic("%s called", __func__);
> +}
> +#endif /* CONFIG_PV */

Do we really need two separate stubs (and two separate string literals)
here?

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel