Re: [Xen-devel] [PATCH 3/3] tools: ipxe: Correct download error handling

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Ian Jackson [mailto:ian.jackson@xxxxxxxxxxxxx]
> Sent: 05 November 2018 18:43
> To: xen-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Ian Jackson <Ian.Jackson@xxxxxxxxxx>; Paul Durrant
> <Paul.Durrant@xxxxxxxxxx>; Wei Liu <wei.liu2@xxxxxxxxxx>
> Subject: [PATCH 3/3] tools: ipxe: Correct download error handling
> 
> This shell fragment lacked set -e.  So, eg if the download failed a
> broken ipxe.tar.gz would be left behind.
> 
> Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> CC: Paul Durrant <paul.durrant@xxxxxxxxxx>
> CC: Wei Liu <wei.liu2@xxxxxxxxxx>

Reviewed-by: Paul Durrant <paul.durrant@xxxxxxxxxx>

> ---
>  tools/firmware/etherboot/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/firmware/etherboot/Makefile
> b/tools/firmware/etherboot/Makefile
> index 3868f876ea..fd8dfdf5a7 100644
> --- a/tools/firmware/etherboot/Makefile
> +++ b/tools/firmware/etherboot/Makefile
> @@ -33,7 +33,7 @@ $(ROM): $(ROMS)
>       $(MAKE) -C $D/src bin/$(*F).rom
> 
>  $T:
> -     if ! $(FETCHER) _$T $(IPXE_TARBALL_URL); then \
> +     set -e; if ! $(FETCHER) _$T $(IPXE_TARBALL_URL); then \
>               $(GIT) clone $(IPXE_GIT_URL) $D.git; \
>               (cd $D.git && $(GIT) archive --format=tar --prefix=$D/ \
>               $(IPXE_GIT_TAG) | gzip -n >../_$T); \
> --
> 2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel