Re: [Xen-devel] [PATCH 3/6] tools/x86emul: Use struct cpuid_policy in the userspace test harnesses

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 05.11.18 at 12:21, <andrew.cooper3@xxxxxxxxxx> wrote:
> +#define cache_line_size() (cp.basic.clflush_size * 8)

While the parentheses are indeed needed here, ...

> +#define cpu_has_mmx       (cp.basic.mmx)

... they could be omitted here. I'd prefer if they were dropped,
but whichever way you decide to do
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel